Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ww setup linter #488

Merged
merged 19 commits into from
Feb 14, 2024
Merged

Ww setup linter #488

merged 19 commits into from
Feb 14, 2024

Conversation

wwhorton
Copy link
Contributor

@wwhorton wwhorton commented Feb 7, 2024

Adds the latest version of ESLint and Prettier, and corrects subsequent errors and warnings.

Additions

  • ESLint
  • Prettier

Changes

  • Modifies existing code to meet ESLint rules, esp. variable name length and unnamed default exports
  • Disables rules where implementation would be counterproductive or unnecessary
  • Fleshes out JSDOC statements

Testing

  • yarn test should pass
  • yarn lint should pass
  • Browse through app and check that it works and looks the same. Please pay particular attention to icons and buttons/anchors as some refactoring was necessary that might have affected styling.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

src/components/Charts/LineChart.js Show resolved Hide resolved
src/components/Map/MapToolbar.js Show resolved Hide resolved
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@flacoman91 flacoman91 added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 2e0792a Feb 14, 2024
2 checks passed
@flacoman91 flacoman91 deleted the ww-setup-linter branch February 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants